feat(Chat): improved styling/readability of markdown tables #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
chat-markdown-tables
branch
from
c07cf7a to
af84e64
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR improves the styling and readability of markdown tables rendered in the chat UI, as well as updates the dependency version for pyright.
- Updated the pyproject.toml file to pin the pyright dependency to a specific version.
- Enhanced the markdown stream renderer to add Bootstrap styling to tables.
- Updated the CHANGELOG.md to document the improvements.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Changed pyright dependency version to a fixed version. |
| js/markdown-stream/markdown-stream.ts | Introduced a new markdown renderer with Bootstrap table styling and updated the HTML escaping renderer. |
| CHANGELOG.md | Added release notes for the markdown table styling improvements. |
Comments suppressed due to low confidence (1)
js/markdown-stream/markdown-stream.ts:53
- The template literal for the table HTML includes extra indentation and newline characters, which may inadvertently render additional whitespace. Consider reformatting the string to minimize unnecessary whitespace, for example by placing the entire HTML structure on one line or carefully managing indentation.
return `<table class="table table-striped table-bordered">
gadenbuie
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1972. For a minimal example:
Before
After